Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5814)

Unified Diff: build/config/compiler/BUILD.gn

Issue 503873004: linux: Always use (64bit) gold for linking, even on 32bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 33d52db4dffbde9cde3d9b51012716984cee911e..9b66b9cb3541a9860eb44a24f3888f597f14c479 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -16,7 +16,7 @@ declare_args() {
android_full_debug = false
}
-use_gold = is_linux && cpu_arch == "x64"
+use_gold = is_linux
# linux_use_debug_fission: whether to use split DWARF debug info
# files. This can reduce link time significantly, but is incompatible
@@ -200,8 +200,8 @@ config("compiler") {
]
}
if (use_gold) {
- # Use gold for linking on 64-bit Linux only (on 32-bit it runs out of
- # address space, and it doesn't support cross-compiling).
+ # 32-bit hosts have to be 32-bit userland with a 64-bit kernel, so that
+ # 64-bit gold gets used. 32-bit gold will run out of address space.
gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
root_build_dir)
ldflags += [
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698