Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 503863002: Address flaky test by waiting for focus change. (Closed)

Created:
6 years, 4 months ago by hcarmona
Modified:
6 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nona+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Address flaky test by waiting for focus change. This change attempts to fix a flaky test by changing the KeyPress function to use SendKeyPressAndWait which will wait for an event. The event that this test will wait for is the focus change event that should get called when an element in the web form changes focus. BUG=405711 Committed: https://crrev.com/b1828abc27926f8f92564ebf21072e98b786fa2a Cr-Commit-Position: refs/heads/master@{#292220}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M chrome/browser/ui/webui/options/language_options_interactive_uitest.cc View 3 chunks +17 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
hcarmona
hcarmona@chromium.org changed reviewers: + msw@chromium.org
6 years, 4 months ago (2014-08-25 22:45:02 UTC) #1
hcarmona
Hi Mike, I wanted to add you as a code reviewer since you're familiar with ...
6 years, 4 months ago (2014-08-25 22:53:15 UTC) #2
msw
Nice, lgtm with a nit. https://codereview.chromium.org/503863002/diff/1/chrome/browser/ui/webui/options/language_options_interactive_uitest.cc File chrome/browser/ui/webui/options/language_options_interactive_uitest.cc (right): https://codereview.chromium.org/503863002/diff/1/chrome/browser/ui/webui/options/language_options_interactive_uitest.cc#newcode64 chrome/browser/ui/webui/options/language_options_interactive_uitest.cc:64: content::RenderViewHost* GetRenderViewHost() { nit: ...
6 years, 3 months ago (2014-08-27 19:01:33 UTC) #3
hcarmona
The CQ bit was checked by hcarmona@chromium.org
6 years, 3 months ago (2014-08-27 20:15:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hcarmona@chromium.org/503863002/1
6 years, 3 months ago (2014-08-27 20:16:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d6108896d719f17c3b7a95e9c734696b8676f52f
6 years, 3 months ago (2014-08-27 21:11:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1828abc27926f8f92564ebf21072e98b786fa2a
Cr-Commit-Position: refs/heads/master@{#292220}

Powered by Google App Engine
This is Rietveld 408576698