Address flaky test by waiting for focus change.

chrome/browser/ui/webui/options/language_options_interactive_uitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
+#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 37 matching lines @@
           GetActiveFrame(),
           get_element_id_script,
           &element_id));
     return element_id;
   }
 
   content::RenderFrameHost* GetActiveFrame() {
     return GetActiveWebContents()->GetFocusedFrame();
   }
 
+  content::RenderViewHost* GetRenderViewHost() {

[msw, 2014/08/27 19:01:33]

nit: this helper seem unnecessary for one call.

+    return GetActiveWebContents()->GetRenderViewHost();
+  }
+
   content::WebContents* GetActiveWebContents() {
     return browser()->tab_strip_model()->GetActiveWebContents();
   }
 
-  // Press and release a key in a particular window. Returns false on error.
+  // Press and release a key in the browser. This will wait for the element on
+  // the page to change.
   bool PressKey(ui::KeyboardCode key_code) {
-    return ui_test_utils::SendKeyPressSync(browser(), key_code,
-                                           false, false, false, false);
+    return ui_test_utils::SendKeyPressAndWait(
+        browser(),
+        key_code,
+        false,
+        false,
+        false,
+        false,
+        content::NOTIFICATION_FOCUS_CHANGED_IN_PAGE,
+        content::Source<content::RenderViewHost>(GetRenderViewHost()));
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(LanguageOptionsWebUITest);
 };
 
 }  // namespace
 
 // This test will verify that the appropriate languages are available.
 // This test will also fail if the language page is not loaded because a random
@@ skipping 28 matching lines @@
       get_children_of_current_element_script,
       &languages));
   EXPECT_EQ("English (United States)SpanishFrench", languages);
 }
 
 // This test will validate that the language webui is accessible through
 // the keyboard.
 // This test must be updated if the tab order of the elements on this page
 // is chagned.
 // flaky: http://crbug.com/405711
-IN_PROC_BROWSER_TEST_F(LanguageOptionsWebUITest,
-                       DISABLED_TestListTabAccessibility) {
+IN_PROC_BROWSER_TEST_F(LanguageOptionsWebUITest, TestListTabAccessibility) {
   // Verify that the language list is focused by default.
   std::string original_id = GetActiveElementId();
   EXPECT_EQ("language-options-list", original_id);
 
   // Press tab to select the next element.
   ASSERT_TRUE(PressKey(ui::VKEY_TAB));
 
   // Make sure that the element is now the button that is next in the tab order.
   // Checking that the list is no longer selected is not sufficient to validate
   // this use case because this test should fail if an item inside the list is
   // selected.
   std::string new_id = GetActiveElementId();
   EXPECT_EQ("language-options-add-button", new_id);
 }
 
 }  // namespace language_options_ui_test