Issue 503763002: DevTools: Test for disabling PortForwardingController

Issue 503763002: DevTools: Test for disabling PortForwardingController (Closed)

Created:
6 years, 3 months ago by vkuzkokov

Modified:
6 years, 3 months ago

Reviewers:
dgozman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: Test for disabling PortForwardingController BUG=407137 Committed: https://crrev.com/90d2910392b6e3838c06cffd3fcbe8fa92311d65 Cr-Commit-Position: refs/heads/master@{#291898}

Patch Set 3 : Fixed test #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	chrome/browser/devtools/device/port_forwarding_browsertest.cc	View	1 2	3 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dgozman

Please specify a BUG number, since there is one. https://codereview.chromium.org/503763002/diff/1/chrome/browser/devtools/device/port_forwarding_browsertest.cc File chrome/browser/devtools/device/port_forwarding_browsertest.cc (right): https://codereview.chromium.org/503763002/diff/1/chrome/browser/devtools/device/port_forwarding_browsertest.cc#newcode119 chrome/browser/devtools/device/port_forwarding_browsertest.cc:119: ...

6 years, 3 months ago (2014-08-25 15:22:05 UTC) #2

vkuzkokov

https://codereview.chromium.org/503763002/diff/1/chrome/browser/devtools/device/port_forwarding_browsertest.cc File chrome/browser/devtools/device/port_forwarding_browsertest.cc (right): https://codereview.chromium.org/503763002/diff/1/chrome/browser/devtools/device/port_forwarding_browsertest.cc#newcode119 chrome/browser/devtools/device/port_forwarding_browsertest.cc:119: prefs->SetBoolean(prefs::kDevToolsPortForwardingEnabled, false); On 2014/08/25 15:22:05, dgozman wrote: > This ...

6 years, 3 months ago (2014-08-25 15:51:26 UTC) #3

dgozman

lgtm https://codereview.chromium.org/503763002/diff/20001/chrome/browser/devtools/device/port_forwarding_browsertest.cc File chrome/browser/devtools/device/port_forwarding_browsertest.cc (right): https://codereview.chromium.org/503763002/diff/20001/chrome/browser/devtools/device/port_forwarding_browsertest.cc#newcode119 chrome/browser/devtools/device/port_forwarding_browsertest.cc:119: // Test that disabling port forwarding is handled ...

6 years, 3 months ago (2014-08-25 16:01:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/503763002/40001

6 years, 3 months ago (2014-08-26 12:34:05 UTC) #6

commit-bot: I haz the power

Committed patchset #3 (40001) as a0c46860efc6570d623aa0822e98c789ebf0ceb8

6 years, 3 months ago (2014-08-26 13:41:59 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:42:38 UTC) #8

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/90d2910392b6e3838c06cffd3fcbe8fa92311d65
Cr-Commit-Position: refs/heads/master@{#291898}

Expand Messages | Collapse Messages