chrome/browser/devtools/device/port_forwarding_browsertest.cc - Issue 503763002: DevTools: Test for disabling PortForwardingController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/devtools/device/port_forwarding_browsertest.cc

Issue 503763002: DevTools: Test for disabling PortForwardingController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/compiler_specific.h"	6 #include "base/compiler_specific.h"

7 #include "base/prefs/pref_service.h"	7 #include "base/prefs/pref_service.h"

8 #include "base/strings/string_number_conversions.h"	8 #include "base/strings/string_number_conversions.h"

9 #include "chrome/browser/devtools/browser_list_tabcontents_provider.h"	9 #include "chrome/browser/devtools/browser_list_tabcontents_provider.h"

10 #include "chrome/browser/devtools/device/port_forwarding_controller.h"	10 #include "chrome/browser/devtools/device/port_forwarding_controller.h"

(...skipping 97 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 "window.domAutomationController.send(getBodyTextContent())",	108 "window.domAutomationController.send(getBodyTextContent())",

109 &result));	109 &result));

110 ASSERT_EQ("content", result) << "Javascript has not loaded.";	110 ASSERT_EQ("content", result) << "Javascript has not loaded.";

111	111

112 ASSERT_TRUE(	112 ASSERT_TRUE(

113 content::ExecuteScriptAndExtractString(	113 content::ExecuteScriptAndExtractString(

114 rvh,	114 rvh,

115 "window.domAutomationController.send(getBodyMarginLeft())",	115 "window.domAutomationController.send(getBodyMarginLeft())",

116 &result));	116 &result));

117 ASSERT_EQ("100px", result) << "CSS has not loaded.";	117 ASSERT_EQ("100px", result) << "CSS has not loaded.";

	118

	119 prefs->SetBoolean(prefs::kDevToolsPortForwardingEnabled, false);
	dgozman 2014/08/25 15:22:05 This needs a comment. Perhaps "Test that disabling This needs a comment. Perhaps "Test that disabling port forwarding does not cause crash". vkuzkokov 2014/08/25 15:51:25 Done. Show quoted text On 2014/08/25 15:22:05, dgozman wrote: > This needs a comment. Perhaps "Test that disabling port forwarding does not > cause crash". Done.
	120 content::RunMessageLoop();

118 }	121 }

OLD	NEW