Issue 503743002: Fix password generation icon sizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 503743002: Fix password generation icon sizing. (Closed)

Created:
6 years, 4 months ago by dconnelly

Modified:
6 years, 3 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix password generation icon sizing. BUG= Committed: https://crrev.com/fe6080fcd10b713bb913553ba8186b36d3b4785b Cr-Commit-Position: refs/heads/master@{#291877}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dconnelly

For some reason I changed the icon sizing in the last patch to use setFrameOrigin: ...

6 years, 4 months ago (2014-08-25 09:49:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/503743002/20001

6 years, 4 months ago (2014-08-26 07:45:53 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (20001) as 591dee9224e811d8d968fd642877a6201090cbb0

6 years, 3 months ago (2014-08-26 10:10:33 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:41:48 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fe6080fcd10b713bb913553ba8186b36d3b4785b
Cr-Commit-Position: refs/heads/master@{#291877}

Expand Messages | Collapse Messages