chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm - Issue 503743002: Fix password generation icon sizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm

Issue 503743002: Fix password generation icon sizing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm

index 5eec7443d37e46d8c4b567e5f25b09493fa982c9..a3db1390b3c7800cd934eae14d2983dd590d3cb2 100644

--- a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm

@@ -206,8 +206,7 @@ NSColor* HelpLinkColor() {

const CGFloat keyY =

std::ceil((controller_->kPopupPasswordSectionHeight / 2.0) -

(imageSize.height / 2.0));

- [keyIcon_ setFrameOrigin:NSMakePoint(keyX, keyY)];

- [keyIcon_ sizeToFit];

+ [keyIcon_ setFrame:{ NSMakePoint(keyX, keyY), imageSize }];

// The title and password fall to the right of the key icon and are centered

// vertically as a group with some padding in between.

« no previous file with comments | « no previous file | no next file » | no next file with comments »