Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 503643002: Add performance test skeleton.

Created:
6 years, 4 months ago by Michael Achenbach
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add performance test skeleton. BUG=406405 LOG=n TEST=tools/run_benchmarks.py --arch=ia32 test/perf-tests/perf-tests.json TEST=tools/run-tests.py --mode=release --arch=ia32 --nopresubmit perf-tests --no-variants

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Total comments: 1

Patch Set 3 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + test/perf-tests/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
A test/perf-tests/infra-test.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + test/perf-tests/perf-tests.gyp View 2 chunks +2 lines, -9 lines 0 comments Download
A test/perf-tests/perf-tests.json View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A + test/perf-tests/perf-tests.status View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/perf-tests/testcfg.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL. I'd probably add one more level of hierarchy to the benchmark runner before landing ...
6 years, 4 months ago (2014-08-24 20:37:57 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/503643002/diff/1/test/perf-tests/infra-test.cc File test/perf-tests/infra-test.cc (right): https://codereview.chromium.org/503643002/diff/1/test/perf-tests/infra-test.cc#newcode11 test/perf-tests/infra-test.cc:11: printf("Trace(Constant), Result(10.0), StdDev(1.0)\n"); How about using the same output ...
6 years, 4 months ago (2014-08-25 04:16:26 UTC) #2
Michael Achenbach
PTAL
6 years, 4 months ago (2014-08-25 06:33:41 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/503643002/diff/20001/test/perf-tests/perf-tests.json File test/perf-tests/perf-tests.json (right): https://codereview.chromium.org/503643002/diff/20001/test/perf-tests/perf-tests.json#newcode7 test/perf-tests/perf-tests.json:7: "unit": "ms" The unit should be part of the ...
6 years, 4 months ago (2014-08-25 06:55:43 UTC) #4
Michael Achenbach
6 years, 4 months ago (2014-08-25 08:15:56 UTC) #5
Done

Powered by Google App Engine
This is Rietveld 408576698