Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issue 50363005: Check that buffer exists before trying to get its duration. (Closed)

Created:
7 years, 1 month ago by Raymond Toy (Google)
Modified:
7 years, 1 month ago
CC:
blink-reviews
Visibility:
Public.

Description

Check that buffer exists before trying to get its duration. Add a simple test for this as well. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161005

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M LayoutTests/webaudio/dom-exceptions.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/webaudio/dom-exceptions-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Raymond Toy (Google)
PTAL
7 years, 1 month ago (2013-10-30 20:48:23 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
7 years, 1 month ago (2013-10-30 23:07:27 UTC) #2
Ken Russell (switch to Gerrit)
P.S. No bug ID?
7 years, 1 month ago (2013-10-30 23:07:50 UTC) #3
Raymond Toy (Google)
On 2013/10/30 23:07:50, Ken Russell wrote: > P.S. No bug ID? Should I file one? ...
7 years, 1 month ago (2013-10-30 23:14:00 UTC) #4
Ken Russell (switch to Gerrit)
On 2013/10/30 23:14:00, rtoy wrote: > On 2013/10/30 23:07:50, Ken Russell wrote: > > P.S. ...
7 years, 1 month ago (2013-10-30 23:17:02 UTC) #5
Raymond Toy (Google)
On 2013/10/30 23:17:02, Ken Russell wrote: > On 2013/10/30 23:14:00, rtoy wrote: > > On ...
7 years, 1 month ago (2013-10-30 23:18:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/50363005/30001
7 years, 1 month ago (2013-10-30 23:18:29 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 02:13:33 UTC) #8
Message was sent while issue was closed.
Change committed as 161005

Powered by Google App Engine
This is Rietveld 408576698