Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 50363005: Check that buffer exists before trying to get its duration. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webaudio/dom-exceptions.html
diff --git a/LayoutTests/webaudio/dom-exceptions.html b/LayoutTests/webaudio/dom-exceptions.html
index 2725a705f1211b5438ce2ff0f06a28803db63329..f9b1e8458b496a44d886a198e4790838f1e2e9ea 100644
--- a/LayoutTests/webaudio/dom-exceptions.html
+++ b/LayoutTests/webaudio/dom-exceptions.html
@@ -121,7 +121,12 @@ function runTest() {
// Start/stop for AudioBufferSourceNodes
buffer = context.createBuffer(1,1, context.sampleRate);
shouldNotThrow("source = context.createBufferSource()");
- source.buffer = buffer;
+ shouldNotThrow("source.buffer = buffer");
+ shouldNotThrow("source.start()");
+ shouldNotThrow("source.stop()");
+
+ // It's valid to start a source that has no associated buffer.
+ shouldNotThrow("source = context.createBufferSource()");
shouldNotThrow("source.start()");
shouldNotThrow("source.stop()");
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698