Issue 503253002: Fixing Windows build

Issue 503253002: Fixing Windows build (Closed)

Created:
6 years, 3 months ago by Charlie

Modified:
6 years, 3 months ago

Reviewers:
rkc

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

This CL repairs a linker error which prevented us from checking in the full copresence implementation under Windows. BUG=407466 Committed: https://crrev.com/7f5a28000b95b4e3a4434563b98d2a2eb45a899a Cr-Commit-Position: refs/heads/master@{#291940}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	components/copresence/rpc/rpc_handler.cc	View	1	3 chunks	+8 lines, -3 lines	2 comments	Download
	M	components/copresence/rpc/rpc_handler_unittest.cc	View		3 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Charlie

ckehoe@chromium.org changed reviewers: + rkc@chromium.org

6 years, 3 months ago (2014-08-26 16:37:50 UTC) #1

Charlie

https://codereview.chromium.org/503253002/diff/20001/components/copresence/rpc/rpc_handler.cc File components/copresence/rpc/rpc_handler.cc (right): https://codereview.chromium.org/503253002/diff/20001/components/copresence/rpc/rpc_handler.cc#newcode19 components/copresence/rpc/rpc_handler.cc:19: #if defined(OS_WIN) Maybe this should say #if defined(DeviceCapabilities) ?

6 years, 3 months ago (2014-08-26 16:37:50 UTC) #2

rkc

lgtm https://codereview.chromium.org/503253002/diff/20001/components/copresence/rpc/rpc_handler.cc File components/copresence/rpc/rpc_handler.cc (right): https://codereview.chromium.org/503253002/diff/20001/components/copresence/rpc/rpc_handler.cc#newcode19 components/copresence/rpc/rpc_handler.cc:19: #if defined(OS_WIN) On 2014/08/26 16:37:50, Charlie wrote: > ...

6 years, 3 months ago (2014-08-26 16:45:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckehoe@chromium.org/503253002/20001

6 years, 3 months ago (2014-08-26 16:51:22 UTC) #5

Charlie

Sending this in. You'll need to request the merge for crbug/407466.

6 years, 3 months ago (2014-08-26 16:52:17 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...

6 years, 3 months ago (2014-08-26 17:47:15 UTC) #7

commit-bot: I haz the power

Committed patchset #2 (20001) as 0f1515418c25454efea85a637c1e076fb8e819c0

6 years, 3 months ago (2014-08-26 18:11:06 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:44:03 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/7f5a28000b95b4e3a4434563b98d2a2eb45a899a
Cr-Commit-Position: refs/heads/master@{#291940}

Expand Messages | Collapse Messages