Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: components/copresence/rpc/rpc_handler_unittest.cc

Issue 503253002: Fixing Windows build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/rpc/rpc_handler_unittest.cc
diff --git a/components/copresence/rpc/rpc_handler_unittest.cc b/components/copresence/rpc/rpc_handler_unittest.cc
index a0fff7412e9c8ee2d953ee29b841fcd56cf09913..db96f4e8be21c59f2c970b6941164e90508a5f56 100644
--- a/components/copresence/rpc/rpc_handler_unittest.cc
+++ b/components/copresence/rpc/rpc_handler_unittest.cc
@@ -108,13 +108,10 @@ class RpcHandlerTest : public testing::Test, public CopresenceDelegate {
return static_cast<ReportRequest*>(request_proto_.get());
}
-// TODO(ckehoe): Fix this on Windows. See rpc_handler.cc.
-#ifndef OS_WIN
const TokenTechnology& GetTokenTechnologyFromReport() {
return GetReportSent()->update_signals_request().state().capabilities()
.token_technology(0);
}
-#endif
const RepeatedPtrField<PublishedMessage>& GetMessagesPublished() {
return GetReportSent()->manage_messages_request().message_to_publish();
@@ -204,9 +201,6 @@ TEST_F(RpcHandlerTest, Initialize) {
EXPECT_FALSE(identity.chrome_id().empty());
}
-// TODO(ckehoe): Fix this on Windows. See rpc_handler.cc.
-#ifndef OS_WIN
-
TEST_F(RpcHandlerTest, GetDeviceCapabilities) {
// Empty request.
rpc_handler_.SendReportRequest(make_scoped_ptr(new ReportRequest));
@@ -254,7 +248,6 @@ TEST_F(RpcHandlerTest, GetDeviceCapabilities) {
EXPECT_EQ(TRANSMIT, token_technology->instruction_type(0));
EXPECT_EQ(RECEIVE, token_technology->instruction_type(1));
}
-#endif
TEST_F(RpcHandlerTest, CreateRequestHeader) {
SetDeviceId("CreateRequestHeader Device ID");
« components/copresence/rpc/rpc_handler.cc ('K') | « components/copresence/rpc/rpc_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698