Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 503243002: In about:gpu page, make sure feature status and problem description match (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

In about:gpu page, make sure feature status and problem description match BUG=405354 TEST=about:gpu page for Win/NVIDIA with driver version forced to "", gpu_unittests R=kbr@chromium.org Committed: https://crrev.com/3f0a6c825a02f72c9bde6d2f074010d090590b7a Cr-Commit-Position: refs/heads/master@{#292103}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/config/gpu_control_list_unittest.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Zhenyao Mo
Please take a look.
6 years, 3 months ago (2014-08-26 01:54:55 UTC) #1
Ken Russell (switch to Gerrit)
Could you please add a test for this case?
6 years, 3 months ago (2014-08-26 02:31:18 UTC) #2
Zhenyao Mo
please take another look. https://codereview.chromium.org/503243002/diff/20001/gpu/config/gpu_control_list_unittest.cc File gpu/config/gpu_control_list_unittest.cc (right): https://codereview.chromium.org/503243002/diff/20001/gpu/config/gpu_control_list_unittest.cc#newcode327 gpu/config/gpu_control_list_unittest.cc:327: EXPECT_EQ(0u, decision_entries.size()); Before the change, ...
6 years, 3 months ago (2014-08-26 02:45:15 UTC) #3
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/503243002/diff/20001/gpu/config/gpu_control_list_unittest.cc File gpu/config/gpu_control_list_unittest.cc (right): https://codereview.chromium.org/503243002/diff/20001/gpu/config/gpu_control_list_unittest.cc#newcode327 gpu/config/gpu_control_list_unittest.cc:327: EXPECT_EQ(0u, decision_entries.size()); On 2014/08/26 02:45:15, Zhenyao Mo wrote: ...
6 years, 3 months ago (2014-08-26 20:49:21 UTC) #4
Zhenyao Mo
https://codereview.chromium.org/503243002/diff/20001/gpu/config/gpu_control_list_unittest.cc File gpu/config/gpu_control_list_unittest.cc (right): https://codereview.chromium.org/503243002/diff/20001/gpu/config/gpu_control_list_unittest.cc#newcode327 gpu/config/gpu_control_list_unittest.cc:327: EXPECT_EQ(0u, decision_entries.size()); On 2014/08/26 20:49:21, Ken Russell wrote: > ...
6 years, 3 months ago (2014-08-27 03:44:06 UTC) #5
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 3 months ago (2014-08-27 03:44:09 UTC) #6
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 3 months ago (2014-08-27 03:44:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/503243002/40001
6 years, 3 months ago (2014-08-27 03:45:06 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 04:56:13 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (40001) as 395912708fc8ecc2882b3441bbcb5cb2618b62b1
6 years, 3 months ago (2014-08-27 06:41:27 UTC) #10
Zhenyao Mo
Patchset #4 (id:60001) has been deleted
6 years, 3 months ago (2014-08-27 19:43:11 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:55 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3f0a6c825a02f72c9bde6d2f074010d090590b7a
Cr-Commit-Position: refs/heads/master@{#292103}

Powered by Google App Engine
This is Rietveld 408576698