In about:gpu page, make sure feature status and problem description match

gpu/config/gpu_control_list_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "gpu/config/gpu_control_list.h"
 #include "gpu/config/gpu_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 271 matching lines @@
   std::set<int> features = control_list->MakeDecision(
       GpuControlList::kOsWin, kOsVersion, gpu_info());
   EXPECT_EMPTY_SET(features);
   std::vector<uint32> flag_entries;
   control_list->GetDecisionEntries(&flag_entries, false);
   EXPECT_EQ(0u, flag_entries.size());
   control_list->GetDecisionEntries(&flag_entries, true);
   EXPECT_EQ(1u, flag_entries.size());
 }
 
+TEST_F(GpuControlListTest, NeedsMoreInfo) {
+  const std::string json = LONG_STRING_CONST(
+      {
+        "name": "gpu control list",
+        "version": "0.1",
+        "entries": [
+          {
+            "id": 1,
+            "os": {
+              "type": "win"
+            },
+            "vendor_id": "0x10de",
+            "driver_version": {
+              "op": "<",
+              "value": "12"
+            },
+            "features": [
+              "test_feature_0"
+            ]
+          }
+        ]
+      }
+  );
+  GPUInfo gpu_info;
+  gpu_info.gpu.vendor_id = kNvidiaVendorId;
+
+  scoped_ptr<GpuControlList> control_list(Create());
+  EXPECT_TRUE(control_list->LoadList(json, GpuControlList::kAllOs));
+
+  std::set<int> features = control_list->MakeDecision(
+      GpuControlList::kOsWin, kOsVersion, gpu_info);
+  EXPECT_EMPTY_SET(features);
+  EXPECT_TRUE(control_list->needs_more_info());
+  std::vector<uint32> decision_entries;
+  control_list->GetDecisionEntries(&decision_entries, false);
+  EXPECT_EQ(0u, decision_entries.size());

[Zhenyao Mo, 2014/08/26 02:45:15]

Before the change, this test fails (returns 1 instead of 0);
After the change, this test passes.

[Ken Russell (switch to Gerrit), 2014/08/26 20:49:21]

OK, sounds good. But should the test also verify the transition from
needs_more_info() returning true to it returning false?

[Zhenyao Mo, 2014/08/27 03:44:05]

Done.

+}
+
 TEST_F(GpuControlListTest, NeedsMoreInfoForExceptions) {
   const std::string json = LONG_STRING_CONST(
       {
         "name": "gpu control list",
         "version": "0.1",
         "entries": [
           {
             "id": 1,
             "os": {
               "type": "linux"
@@ skipping 232 matching lines @@
     // For non AMD switchable
     gpu_info.amd_switchable = false;
     features = control_list->MakeDecision(
         GpuControlList::kOsWin, kOsVersion, gpu_info);
     EXPECT_EMPTY_SET(features);
   }
 }
 
 }  // namespace gpu