chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc - Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_web_view_internal

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

index 767b44424fa926d8ba6675458beed562c5d008fe..9ab0684cc40428d481edf2cdcdec58acdd970a98 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

@@ -8,8 +8,6 @@

#include "base/metrics/histogram.h"

#include "base/time/time.h"

#include "chrome/browser/extensions/extension_service.h"

-#include "chrome/browser/extensions/extension_warning_service.h"

-#include "chrome/browser/extensions/extension_warning_set.h"

#include "chrome/browser/extensions/updater/extension_updater.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -19,6 +17,8 @@

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/notification_types.h"

+#include "extensions/browser/warning_service.h"

+#include "extensions/browser/warning_set.h"

#include "extensions/common/api/runtime.h"

#if defined(OS_CHROMEOS)

@@ -120,13 +120,13 @@ void ChromeRuntimeAPIDelegate::ReloadExtension(

base::Bind(&ExtensionService::TerminateExtension,

service->AsWeakPtr(),

extension_id));

- extensions::ExtensionWarningSet warnings;

+ extensions::WarningSet warnings;

warnings.insert(

- extensions::ExtensionWarning::CreateReloadTooFrequentWarning(

+ extensions::Warning::CreateReloadTooFrequentWarning(

extension_id));

base::MessageLoop::current()->PostTask(

FROM_HERE,

- base::Bind(&extensions::ExtensionWarningService::NotifyWarningsOnUI,

+ base::Bind(&extensions::WarningService::NotifyWarningsOnUI,

browser_context_,

warnings));

} else {