chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_web_view_internal

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index 18c536f2fb98e952ee54fbecfd615013e2b71f11..d513b9ff21bcc12d7a6b97ff9f1d97b2a30c6951 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -4096,7 +4096,7 @@ TEST(ExtensionDetermineDownloadFilenameInternal,

base::FilePath filename;

downloads::FilenameConflictAction conflict_action =

downloads::FILENAME_CONFLICT_ACTION_UNIQUIFY;

- ExtensionWarningSet warnings;

+ WarningSet warnings;

// Empty incumbent determiner

warnings.clear();

@@ -4133,7 +4133,7 @@ TEST(ExtensionDetermineDownloadFilenameInternal,

EXPECT_EQ(FILE_PATH_LITERAL("a"), filename.value());

EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_OVERWRITE, conflict_action);

EXPECT_FALSE(warnings.empty());

- EXPECT_EQ(ExtensionWarning::kDownloadFilenameConflict,

+ EXPECT_EQ(Warning::kDownloadFilenameConflict,

warnings.begin()->warning_type());

EXPECT_EQ("suggester", warnings.begin()->extension_id());

@@ -4154,7 +4154,7 @@ TEST(ExtensionDetermineDownloadFilenameInternal,

EXPECT_EQ(FILE_PATH_LITERAL("b"), filename.value());

EXPECT_EQ(downloads::FILENAME_CONFLICT_ACTION_PROMPT, conflict_action);

EXPECT_FALSE(warnings.empty());

- EXPECT_EQ(ExtensionWarning::kDownloadFilenameConflict,

+ EXPECT_EQ(Warning::kDownloadFilenameConflict,

warnings.begin()->warning_type());

EXPECT_EQ("incumbent", warnings.begin()->extension_id());

}