Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: extensions/browser/warning_service.cc

Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_web_view_internal
Patch Set: Rename. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/warning_service.cc
diff --git a/extensions/browser/warning_service.cc b/extensions/browser/warning_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..da3feb47020505d9805f670acfec875362bac472
--- /dev/null
+++ b/extensions/browser/warning_service.cc
@@ -0,0 +1,127 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
James Cook 2014/08/26 22:01:31 nit: Try uploading this file with "git cl upload -
Xi Han 2014/08/27 13:32:54 Great suggestion, I will do it for next cl upload.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/warning_service.h"
+
+#include "content/public/browser/browser_thread.h"
+#include "extensions/browser/extension_registry.h"
+#include "extensions/browser/extension_system.h"
+#include "extensions/browser/extensions_browser_client.h"
+#include "extensions/common/extension_set.h"
+
+using content::BrowserThread;
+
+namespace extensions {
+
+WarningService::WarningService(content::BrowserContext* browser_context)
+ : browser_context_(browser_context), extension_registry_observer_(this) {
+ DCHECK(CalledOnValidThread());
+ if (browser_context_) {
+ extension_registry_observer_.Add(ExtensionRegistry::Get(
+ ExtensionsBrowserClient::Get()->GetOriginalContext(browser_context_)));
+ }
+}
+
+WarningService::~WarningService() {}
+
+void WarningService::ClearWarnings(
+ const std::set<Warning::WarningType>& types) {
+ DCHECK(CalledOnValidThread());
+ bool deleted_anything = false;
+ for (WarningSet::iterator i = warnings_.begin();
+ i != warnings_.end();) {
+ if (types.find(i->warning_type()) != types.end()) {
+ deleted_anything = true;
+ warnings_.erase(i++);
+ } else {
+ ++i;
+ }
+ }
+
+ if (deleted_anything)
+ NotifyWarningsChanged();
+}
+
+std::set<Warning::WarningType> WarningService::
+ GetWarningTypesAffectingExtension(const std::string& extension_id) const {
+ DCHECK(CalledOnValidThread());
+ std::set<Warning::WarningType> result;
+ for (WarningSet::const_iterator i = warnings_.begin();
+ i != warnings_.end(); ++i) {
+ if (i->extension_id() == extension_id)
+ result.insert(i->warning_type());
+ }
+ return result;
+}
+
+std::vector<std::string> WarningService::GetWarningMessagesForExtension(
+ const std::string& extension_id) const {
+ DCHECK(CalledOnValidThread());
+ std::vector<std::string> result;
+
+ const ExtensionSet& extension_set =
+ ExtensionRegistry::Get(browser_context_)->enabled_extensions();
+
+ for (WarningSet::const_iterator i = warnings_.begin();
+ i != warnings_.end(); ++i) {
+ if (i->extension_id() == extension_id)
+ result.push_back(i->GetLocalizedMessage(&extension_set));
+ }
+ return result;
+}
+
+void WarningService::AddWarnings(const WarningSet& warnings) {
+ DCHECK(CalledOnValidThread());
+ size_t old_size = warnings_.size();
+
+ warnings_.insert(warnings.begin(), warnings.end());
+
+ if (old_size != warnings_.size())
+ NotifyWarningsChanged();
+}
+
+// static
+void WarningService::NotifyWarningsOnUI(
+ void* profile_id,
+ const WarningSet& warnings) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ content::BrowserContext* browser_context =
+ reinterpret_cast<content::BrowserContext*>(profile_id);
+
+ if (!browser_context ||
+ !ExtensionsBrowserClient::Get() ||
+ !ExtensionsBrowserClient::Get()->IsValidContext(browser_context)) {
+ return;
+ }
+
+ extensions::WarningService* warning_service =
James Cook 2014/08/26 22:01:31 nit: "extensions::" not needed
Xi Han 2014/08/27 13:32:55 Done.
+ extensions::ExtensionSystem::Get(browser_context)->warning_service();
+
+ warning_service->AddWarnings(warnings);
+}
+
+void WarningService::AddObserver(Observer* observer) {
+ observer_list_.AddObserver(observer);
+}
+
+void WarningService::RemoveObserver(Observer* observer) {
+ observer_list_.RemoveObserver(observer);
+}
+
+void WarningService::NotifyWarningsChanged() {
+ FOR_EACH_OBSERVER(Observer, observer_list_, ExtensionWarningsChanged());
+}
+
+void WarningService::OnExtensionUnloaded(
+ content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) {
+ // Unloading one extension might have solved the problems of others.
+ // Therefore, we clear warnings of this type for all extensions.
+ std::set<Warning::WarningType> warning_types =
+ GetWarningTypesAffectingExtension(extension->id());
+ ClearWarnings(warning_types);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698