chrome/common/extensions/chrome_extensions_client.cc - Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 503033002: Move ExtensionWarningService and ExtensionsWarningSet to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_web_view_internal

Patch Set: Rename. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_warning_badge_service_unittest.cc ('K') | « chrome/common/extensions/chrome_extensions_client.h ('k') | extensions/browser/extension_system.h » ('j') | extensions/browser/warning_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/chrome_extensions_client.cc

diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc

index 80befd80209a5145a68e79fa4424833ffcbaf740..9b4622b262beff8deaa38fa80a4fdc6cd7feb5b5 100644

--- a/chrome/common/extensions/chrome_extensions_client.cc

+++ b/chrome/common/extensions/chrome_extensions_client.cc

@@ -33,6 +33,7 @@

#include "extensions/common/url_pattern.h"

#include "extensions/common/url_pattern_set.h"

#include "extensions/grit/extensions_resources.h"

+#include "grit/chromium_strings.h"

James Cook 2014/08/26 22:01:31 nit: I think we're using chrome/grit/chromium_stri

Xi Han 2014/08/27 13:32:54 Great catch, thanks!

#include "ui/base/l10n/l10n_util.h"

#include "url/gurl.h"

@@ -100,6 +101,10 @@ ChromeExtensionsClient::GetPermissionMessageProvider() const {

return permission_message_provider_;

}

+const std::string ChromeExtensionsClient::GetProductName() {

+ return l10n_util::GetStringUTF8(IDS_PRODUCT_NAME);

scoped_ptr<FeatureProvider> ChromeExtensionsClient::CreateFeatureProvider(

const std::string& name) const {

scoped_ptr<FeatureProvider> provider;