Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: src/lookup-inl.h

Issue 502903002: Remove HolderIsNonGlobalHiddenPrototype since OWN* now also checks globals (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove explicit JSGlobalObject check since it's always either that or Null Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup-inl.h
diff --git a/src/lookup-inl.h b/src/lookup-inl.h
index ae4b66df01d74c662bd58dc1a9c18427bd6dafc8..d87221e7c913d60be0ebbc8938e47f13e87482fe 100644
--- a/src/lookup-inl.h
+++ b/src/lookup-inl.h
@@ -23,7 +23,7 @@ JSReceiver* LookupIterator::NextHolder(Map* map) {
!(check_hidden() && next->map()->is_hidden_prototype()) &&
// Always lookup behind the JSGlobalProxy into the JSGlobalObject, even
// when not checking other hidden prototypes.
mvstanton 2014/08/25 11:10:02 Could you update this comment?
Toon Verwaest 2014/08/25 11:36:27 The comment is still valid. We just don't need to
mvstanton 2014/08/25 11:48:24 Yes, okay. If you have a JSGlobalProxy, then you k
- !(map->IsJSGlobalProxyMap() && next->IsJSGlobalObject())) {
+ !map->IsJSGlobalProxyMap()) {
return NULL;
}
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698