Remove HolderIsNonGlobalHiddenPrototype since OWN* now also checks globals

src/lookup-inl.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_LOOKUP_INL_H_
 #define V8_LOOKUP_INL_H_
 
 #include "src/lookup.h"
 
 namespace v8 {
 namespace internal {
 
 
 JSReceiver* LookupIterator::NextHolder(Map* map) {
   DisallowHeapAllocation no_gc;
   if (map->prototype()->IsNull()) return NULL;
 
   JSReceiver* next = JSReceiver::cast(map->prototype());
   DCHECK(!next->map()->IsGlobalObjectMap() ||
          next->map()->is_hidden_prototype());
 
   if (!check_prototype_chain() &&
       !(check_hidden() && next->map()->is_hidden_prototype()) &&
       // Always lookup behind the JSGlobalProxy into the JSGlobalObject, even
       // when not checking other hidden prototypes.

[mvstanton, 2014/08/25 11:10:02]

Could you update this comment?

[Toon Verwaest, 2014/08/25 11:36:27]

The comment is still valid. We just don't need to check whether it is the global
object.

[mvstanton, 2014/08/25 11:48:24]

Yes, okay. If you have a JSGlobalProxy, then you know there is a JSGlobalObject
behind, and you return it down on line 30.

-      !(map->IsJSGlobalProxyMap() && next->IsJSGlobalObject())) {
+      !map->IsJSGlobalProxyMap()) {
     return NULL;
   }
 
   return next;
 }
 
 
 LookupIterator::State LookupIterator::LookupInHolder(Map* map) {
   STATIC_ASSERT(INTERCEPTOR == BEFORE_PROPERTY);
   DisallowHeapAllocation no_gc;
@@ skipping 27 matching lines @@
     case TRANSITION:
       UNREACHABLE();
   }
   UNREACHABLE();
   return state_;
 }
 }
 }  // namespace v8::internal
 
 #endif  // V8_LOOKUP_INL_H_