Issue 502903002: Remove HolderIsNonGlobalHiddenPrototype since OWN* now also checks globals

Issue 502903002: Remove HolderIsNonGlobalHiddenPrototype since OWN* now also checks globals (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove HolderIsNonGlobalHiddenPrototype since OWN* now also checks globals BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23351

Patch Set 2 : Remove explicit JSGlobalObject check since it's always either that or Null #

Total comments: 3

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -15 lines)			Patch
M	src/lookup.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/lookup.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/lookup-inl.h	View	1	1 chunk	+1 line, -1 line	3 comments	Download
M	src/objects.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mvstanton

One comment/nit but LGTM. https://codereview.chromium.org/502903002/diff/20001/src/lookup-inl.h File src/lookup-inl.h (right): https://codereview.chromium.org/502903002/diff/20001/src/lookup-inl.h#newcode25 src/lookup-inl.h:25: // when not checking other ...

6 years, 4 months ago (2014-08-25 11:10:02 UTC) #2

Toon Verwaest

https://codereview.chromium.org/502903002/diff/20001/src/lookup-inl.h File src/lookup-inl.h (right): https://codereview.chromium.org/502903002/diff/20001/src/lookup-inl.h#newcode25 src/lookup-inl.h:25: // when not checking other hidden prototypes. On 2014/08/25 ...

6 years, 4 months ago (2014-08-25 11:36:27 UTC) #3

Toon Verwaest

Committed patchset #2 manually as 23351 (presubmit successful).

6 years, 4 months ago (2014-08-25 11:47:38 UTC) #4

mvstanton

6 years, 4 months ago (2014-08-25 11:48:24 UTC) #5

Message was sent while issue was closed.

OKay I see.

https://codereview.chromium.org/502903002/diff/20001/src/lookup-inl.h
File src/lookup-inl.h (right):

https://codereview.chromium.org/502903002/diff/20001/src/lookup-inl.h#newcode25
src/lookup-inl.h:25: // when not checking other hidden prototypes.
On 2014/08/25 11:36:27, Toon Verwaest wrote:
> On 2014/08/25 11:10:02, mvstanton wrote:
> > Could you update this comment?
> 
> The comment is still valid. We just don't need to check whether it is the
global
> object.

Yes, okay. If you have a JSGlobalProxy, then you know there is a JSGlobalObject
behind, and you return it down on line 30.

Expand Messages | Collapse Messages