Issue 502593003: Cleanup: Fix some lint errors in chrome/browser/ui.

Issue 502593003: Cleanup: Fix some lint errors in chrome/browser/ui. (Closed)

Created:
6 years, 4 months ago by Lei Zhang

Modified:
6 years, 3 months ago

Reviewers:
Mr4D (OOO till 08-26)

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: Fix some lint errors in chrome/browser/ui. Committed: https://crrev.com/6e80cfe631869af6c45ca499321e9a9657a0f261 Cr-Commit-Position: refs/heads/master@{#291601}

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/l10n_util.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc	View	3 chunks	+5 lines, -6 lines	2 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

lgtm https://codereview.chromium.org/502593003/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right): https://codereview.chromium.org/502593003/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc#newcode246 chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:246: : handler(handler) {} Why did you remove the ...

6 years, 4 months ago (2014-08-23 00:05:47 UTC) #2

Lei Zhang

https://codereview.chromium.org/502593003/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right): https://codereview.chromium.org/502593003/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc#newcode246 chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:246: : handler(handler) {} On 2014/08/23 00:05:47, Mr4D wrote: > ...

6 years, 4 months ago (2014-08-23 00:37:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/502593003/1

6 years, 4 months ago (2014-08-23 04:56:22 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-23 06:48:21 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (1) as 9afdcdf1f83ea9160664ba90637b9155595701be

6 years, 4 months ago (2014-08-23 22:02:08 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:31:48 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6e80cfe631869af6c45ca499321e9a9657a0f261
Cr-Commit-Position: refs/heads/master@{#291601}

Expand Messages | Collapse Messages