Chromium Code Reviews| Index: chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc |
| diff --git a/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc |
| index 06724e71ece53e75b0bf5907d08c385902d73111..3e1d1b54cec6b36077423028b8a6f717a3cad6a7 100644 |
| --- a/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc |
| +++ b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc |
| @@ -50,7 +50,6 @@ const char kJsApiNetworkOnTimezoneChanged[] = "networkOnTimezoneChanged"; |
| // "selected" only if loaded_locale is a backup for "requested_locale". |
| std::string CalculateSelectedLanguage(const std::string& requested_locale, |
| const std::string& loaded_locale) { |
| - |
| std::string resolved_locale; |
| if (!l10n_util::CheckAndResolveLocale(requested_locale, &resolved_locale)) |
| return loaded_locale; |
| @@ -243,10 +242,10 @@ void NetworkScreenHandler::HandleOnExit() { |
| struct NetworkScreenHandlerOnLanguageChangedCallbackData { |
| explicit NetworkScreenHandlerOnLanguageChangedCallbackData( |
| - base::WeakPtr<NetworkScreenHandler>& handler) |
| - : handler_(handler) {} |
| + const base::WeakPtr<NetworkScreenHandler>& handler) |
| + : handler(handler) {} |
|
Mr4D (OOO till 08-26)
2014/08/23 00:05:47
Why did you remove the '_' here? It is a class var
Lei Zhang
2014/08/23 00:37:31
structs do not have the '_' suffix. See how |handl
|
| - base::WeakPtr<NetworkScreenHandler> handler_; |
| + base::WeakPtr<NetworkScreenHandler> handler; |
| // Block UI while resource bundle is being reloaded. |
| chromeos::InputEventsBlocker input_events_blocker; |
| @@ -258,10 +257,10 @@ void NetworkScreenHandler::OnLanguageChangedCallback( |
| const std::string& requested_locale, |
| const std::string& loaded_locale, |
| const bool success) { |
| - if (!context or !context->handler_) |
| + if (!context || !context->handler) |
| return; |
| - NetworkScreenHandler* const self = context->handler_.get(); |
| + NetworkScreenHandler* const self = context->handler.get(); |
| if (success) { |
| if (requested_locale == loaded_locale) { |