Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: mojo/system/multiprocess_message_pipe_unittest.cc

Issue 502573006: Remove implicit conversions from scoped_refptr to T* in mojo/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/system/multiprocess_message_pipe_unittest.cc
diff --git a/mojo/system/multiprocess_message_pipe_unittest.cc b/mojo/system/multiprocess_message_pipe_unittest.cc
index bccf08c4d020606584015a6050f90580fa807ffb..a2250ea913d46e1ce72264c886046365e3e337dd 100644
--- a/mojo/system/multiprocess_message_pipe_unittest.cc
+++ b/mojo/system/multiprocess_message_pipe_unittest.cc
@@ -59,7 +59,7 @@ class ChannelThread {
}
void Stop() {
- if (channel_) {
+ if (channel_.get()) {
// Hack to flush write buffers before quitting.
// TODO(vtl): Remove this once |Channel| has a
// |FlushWriteBufferAndShutdown()| (or whatever).
@@ -98,7 +98,7 @@ class ChannelThread {
}
void ShutdownChannelOnIOThread() {
- CHECK(channel_);
+ CHECK(channel_.get());
channel_->Shutdown();
channel_ = NULL;
}
@@ -442,7 +442,7 @@ TEST_F(MultiprocessMessagePipeTest, MAYBE_SharedBufferPassing) {
SharedBufferDispatcher::kDefaultCreateOptions,
100,
&dispatcher));
- ASSERT_TRUE(dispatcher);
+ ASSERT_TRUE(dispatcher.get());
// Make a mapping.
scoped_ptr<embedder::PlatformSharedBufferMapping> mapping;

Powered by Google App Engine
This is Rietveld 408576698