Remove implicit conversions from scoped_refptr to T* in mojo/

mojo/system/channel.cc

Index: mojo/system/channel.cc
diff --git a/mojo/system/channel.cc b/mojo/system/channel.cc
index c0b68f1a5fc84d2fcb3b8aa892389ccd6e60b992..78bd42805f95fe9a910e1dfe730cbfeec9e1cfe1 100644
--- a/mojo/system/channel.cc
+++ b/mojo/system/channel.cc
@@ -88,7 +88,7 @@ void Channel::Shutdown() {
       it->second.message_pipe->OnRemove(it->second.port);
       num_live++;
     } else {
-      DCHECK(!it->second.message_pipe);
+      DCHECK(!it->second.message_pipe.get());

[viettrungluu, 2014/08/25 19:57:05]

Eh? This is a truth (i.e., (non)null) check. Which shouldn't get converted, no?

[dcheng, 2014/08/25 19:58:29]

I can't add a boolean test to scoped_refptr until all implicit conversions to T*
have been removed on a platform. The conversion would be ambiguous otherwise.

       num_zombies++;
     }
   }
@@ -105,7 +105,7 @@ void Channel::WillShutdownSoon() {
 MessageInTransit::EndpointId Channel::AttachMessagePipeEndpoint(
     scoped_refptr<MessagePipe> message_pipe,
     unsigned port) {
-  DCHECK(message_pipe);
+  DCHECK(message_pipe.get());

[viettrungluu, 2014/08/25 19:57:04]

"

   DCHECK(port == 0 || port == 1);
 
   MessageInTransit::EndpointId local_id;