Remove implicit conversions from scoped_refptr to T* in mojo/

mojo/system/channel.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/channel.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 70 matching lines @@
 
   size_t num_live = 0;
   size_t num_zombies = 0;
   for (IdToEndpointInfoMap::iterator it = to_destroy.begin();
        it != to_destroy.end();
        ++it) {
     if (it->second.state == EndpointInfo::STATE_NORMAL) {
       it->second.message_pipe->OnRemove(it->second.port);
       num_live++;
     } else {
-      DCHECK(!it->second.message_pipe);
+      DCHECK(!it->second.message_pipe.get());

[viettrungluu, 2014/08/25 19:57:05]

Eh? This is a truth (i.e., (non)null) check. Which shouldn't get converted, no?

[dcheng, 2014/08/25 19:58:29]

I can't add a boolean test to scoped_refptr until all implicit conversions to T*
have been removed on a platform. The conversion would be ambiguous otherwise.

       num_zombies++;
     }
   }
   DVLOG_IF(2, num_live || num_zombies) << "Shut down Channel with " << num_live
                                        << " live endpoints and " << num_zombies
                                        << " zombies";
 }
 
 void Channel::WillShutdownSoon() {
   base::AutoLock locker(lock_);
   is_shutting_down_ = true;
 }
 
 MessageInTransit::EndpointId Channel::AttachMessagePipeEndpoint(
     scoped_refptr<MessagePipe> message_pipe,
     unsigned port) {
-  DCHECK(message_pipe);
+  DCHECK(message_pipe.get());

[viettrungluu, 2014/08/25 19:57:04]

"

   DCHECK(port == 0 || port == 1);
 
   MessageInTransit::EndpointId local_id;
   {
     base::AutoLock locker(lock_);
 
     DLOG_IF(WARNING, is_shutting_down_)
         << "AttachMessagePipeEndpoint() while shutting down";
 
     while (next_local_id_ == MessageInTransit::kInvalidEndpointId ||
@@ skipping 405 matching lines @@
   // TODO(vtl): Is this how we really want to handle this?
   // Sometimes we'll want to propagate the error back to the message pipe
   // (endpoint), and notify it that the remote is (effectively) closed.
   // Sometimes we'll want to kill the channel (and notify all the endpoints that
   // their remotes are dead.
   LOG(WARNING) << error_message;
 }
 
 }  // namespace system
 }  // namespace mojo