Find HID report IDs in output and feature reports on Windows.

Find HID report IDs in output and feature reports on Windows.

A device may only have HID output or feature reports. In this case we
missed report IDs associated with this reports. This patch uses Window's
HID descriptor parser to scan though all report types looking for HID
collection information.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291553

[rpaquay, 2014-08-22 21:36:31]

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.cc
File device/hid/hid_service_win.cc (right):

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.c...
device/hid/hid_service_win.cc:162: for (int i = 0; i < button_caps_length; i++)
{
Should "i" be unsigned (size_t)?

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.c...
device/hid/hid_service_win.cc:183: for (int i = 0; i < value_caps_length; i++) {
Should "i" be unsigned (size_t)?

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.h
File device/hid/hid_service_win.h (right):

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.h...
device/hid/hid_service_win.h:15: #define INITGUID
I am surprised this works, as usually INITGUID is used in .cc files to avoid
defining the same GUID multiple times and getting linker errors. Am I missing
something?

[Reilly Grant (use Gerrit), 2014-08-22 21:54:54]

Switched to using unsigned types and moved the INITGUID #define back to
hid_service_win.cc.

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.cc
File device/hid/hid_service_win.cc (right):

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.c...
device/hid/hid_service_win.cc:162: for (int i = 0; i < button_caps_length; i++)
{
On 2014/08/22 21:36:30, rpaquay wrote:
> Should "i" be unsigned (size_t)?

Done.

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.c...
device/hid/hid_service_win.cc:183: for (int i = 0; i < value_caps_length; i++) {
On 2014/08/22 21:36:30, rpaquay wrote:
> Should "i" be unsigned (size_t)?

Done.

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.h
File device/hid/hid_service_win.h (right):

https://codereview.chromium.org/502573002/diff/1/device/hid/hid_service_win.h...
device/hid/hid_service_win.h:15: #define INITGUID
On 2014/08/22 21:36:30, rpaquay wrote:
> I am surprised this works, as usually INITGUID is used in .cc files to avoid
> defining the same GUID multiple times and getting linker errors. Am I missing
> something?

It works but probably only because of the limited usage of this header. I move
it when chasing another compilation issue but it wasn't necessary.

[rpaquay, 2014-08-22 21:56:07]

lgtm

[Reilly Grant (use Gerrit), 2014-08-22 21:57:40]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-08-22 22:00:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reillyg@chromium.org/502573002/20001

[commit-bot: I haz the power, 2014-08-22 23:30:38]

Committed patchset #2 (20001) as 291553