Find HID report IDs in output and feature reports on Windows.

device/hid/hid_service_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/hid/hid_service_win.h"
 
 #include <cstdlib>
 
 #include "base/files/file.h"
 #include "base/stl_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "device/hid/hid_connection_win.h"
 #include "device/hid/hid_device_info.h"
 #include "net/base/io_buffer.h"
 
 #if defined(OS_WIN)
 
-#define INITGUID
-
-#include <windows.h>
-#include <hidclass.h>
-
-extern "C" {
-
-#include <hidsdi.h>
-#include <hidpi.h>
-
-}
-
 #include <setupapi.h>
 #include <winioctl.h>
 #include "base/win/scoped_handle.h"
 
 #endif  // defined(OS_WIN)
 
 // Setup API is required to enumerate HID devices.
 #pragma comment(lib, "setupapi.lib")
 #pragma comment(lib, "hid.lib")
 
@@ skipping 112 matching lines @@
       disconnected_devices.push_back(it->first);
     }
   }
 
   // Remove disconnected devices.
   for (size_t i = 0; i < disconnected_devices.size(); ++i) {
     PlatformRemoveDevice(disconnected_devices[i]);
   }
 }
 
+void HidServiceWin::CollectInfoFromButtonCaps(
+    PHIDP_PREPARSED_DATA preparsed_data,
+    HIDP_REPORT_TYPE report_type,
+    USHORT button_caps_length,
+    HidCollectionInfo* collection_info) {
+  if (button_caps_length > 0) {
+    scoped_ptr<HIDP_BUTTON_CAPS[]> button_caps(
+        new HIDP_BUTTON_CAPS[button_caps_length]);
+    if (HidP_GetButtonCaps(report_type,
+                           &button_caps[0],
+                           &button_caps_length,
+                           preparsed_data) == HIDP_STATUS_SUCCESS) {
+      for (int i = 0; i < button_caps_length; i++) {

[rpaquay, 2014/08/22 21:36:30]

Should "i" be unsigned (size_t)?

[Reilly Grant (use Gerrit), 2014/08/22 21:54:54]

Done.

+        int report_id = button_caps[i].ReportID;
+        if (report_id != 0) {
+          collection_info->report_ids.insert(report_id);
+        }
+      }
+    }
+  }
+}
+
+void HidServiceWin::CollectInfoFromValueCaps(
+    PHIDP_PREPARSED_DATA preparsed_data,
+    HIDP_REPORT_TYPE report_type,
+    USHORT value_caps_length,
+    HidCollectionInfo* collection_info) {
+  if (value_caps_length > 0) {
+    scoped_ptr<HIDP_VALUE_CAPS[]> value_caps(
+        new HIDP_VALUE_CAPS[value_caps_length]);
+    if (HidP_GetValueCaps(
+            report_type, &value_caps[0], &value_caps_length, preparsed_data) ==
+        HIDP_STATUS_SUCCESS) {
+      for (int i = 0; i < value_caps_length; i++) {

[rpaquay, 2014/08/22 21:36:30]

Should "i" be unsigned (size_t)?

[Reilly Grant (use Gerrit), 2014/08/22 21:54:54]

Done.

+        int report_id = value_caps[i].ReportID;
+        if (report_id != 0) {
+          collection_info->report_ids.insert(report_id);
+        }
+      }
+    }
+  }
+}
+
 void HidServiceWin::PlatformAddDevice(const std::string& device_path) {
   HidDeviceInfo device_info;
   device_info.device_id = device_path;
 
   // Try to open the device.
   base::win::ScopedHandle device_handle(
       CreateFileA(device_path.c_str(),
                   GENERIC_WRITE | GENERIC_READ,
                   FILE_SHARE_READ | FILE_SHARE_WRITE,
                   NULL,
@@ skipping 36 matching lines @@
     HIDP_CAPS capabilities = {0};
     if (HidP_GetCaps(preparsed_data, &capabilities) == HIDP_STATUS_SUCCESS) {
       device_info.max_input_report_size = capabilities.InputReportByteLength;
       device_info.max_output_report_size = capabilities.OutputReportByteLength;
       device_info.max_feature_report_size =
           capabilities.FeatureReportByteLength;
       HidCollectionInfo collection_info;
       collection_info.usage = HidUsageAndPage(
           capabilities.Usage,
           static_cast<HidUsageAndPage::Page>(capabilities.UsagePage));
-      USHORT button_caps_length = capabilities.NumberInputButtonCaps;
-      if (button_caps_length > 0) {
-        scoped_ptr<HIDP_BUTTON_CAPS[]> button_caps(
-            new HIDP_BUTTON_CAPS[button_caps_length]);
-        if (HidP_GetButtonCaps(HidP_Input,
-                               &button_caps[0],
-                               &button_caps_length,
-                               preparsed_data) == HIDP_STATUS_SUCCESS) {
-          for (int i = 0; i < button_caps_length; i++) {
-            int report_id = button_caps[i].ReportID;
-            if (report_id != 0) {
-              collection_info.report_ids.insert(report_id);
-              device_info.has_report_id = true;
-            }
-          }
-        }
-      }
-      USHORT value_caps_length = capabilities.NumberInputValueCaps;
-      if (value_caps_length > 0) {
-        scoped_ptr<HIDP_VALUE_CAPS[]> value_caps(
-            new HIDP_VALUE_CAPS[value_caps_length]);
-        if (HidP_GetValueCaps(HidP_Input,
-                              &value_caps[0],
-                              &value_caps_length,
-                              preparsed_data) == HIDP_STATUS_SUCCESS) {
-          for (int i = 0; i < value_caps_length; i++) {
-            int report_id = value_caps[i].ReportID;
-            if (report_id != 0) {
-              collection_info.report_ids.insert(report_id);
-              device_info.has_report_id = true;
-            }
-          }
-        }
+      CollectInfoFromButtonCaps(preparsed_data,
+                                HidP_Input,
+                                capabilities.NumberInputButtonCaps,
+                                &collection_info);
+      CollectInfoFromButtonCaps(preparsed_data,
+                                HidP_Output,
+                                capabilities.NumberOutputButtonCaps,
+                                &collection_info);
+      CollectInfoFromButtonCaps(preparsed_data,
+                                HidP_Feature,
+                                capabilities.NumberFeatureButtonCaps,
+                                &collection_info);
+      CollectInfoFromValueCaps(preparsed_data,
+                               HidP_Input,
+                               capabilities.NumberInputValueCaps,
+                               &collection_info);
+      CollectInfoFromValueCaps(preparsed_data,
+                               HidP_Output,
+                               capabilities.NumberOutputValueCaps,
+                               &collection_info);
+      CollectInfoFromValueCaps(preparsed_data,
+                               HidP_Feature,
+                               capabilities.NumberFeatureValueCaps,
+                               &collection_info);
+      if (!collection_info.report_ids.empty()) {
+        device_info.has_report_id = true;
       }
       device_info.collections.push_back(collection_info);
     }
     // Whether or not the device includes report IDs in its reports the size
     // of the report ID is included in the value provided by Windows. This
     // appears contrary to the MSDN documentation.
     if (device_info.max_input_report_size > 0) {
       device_info.max_input_report_size--;
     }
     if (device_info.max_output_report_size > 0) {
@@ skipping 24 matching lines @@
     return NULL;
   scoped_refptr<HidConnectionWin> connection(new HidConnectionWin(device_info));
   if (!connection->available()) {
     PLOG(ERROR) << "Failed to open device.";
     return NULL;
   }
   return connection;
 }
 
 }  // namespace device