Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 502533004: Revert of Make setVertexAttribs in GrDrawState take a stride parameter. (Closed)

Created:
6 years, 3 months ago by djsollen
Modified:
6 years, 3 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Make setVertexAttribs in GrDrawState take a stride parameter. (patchset #5 of https://codereview.chromium.org/511593004/) Reason for revert: GM failures on http://108.170.220.120:10115/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/1867/ Original issue's description: > Make setVertexAttribs in GrDrawState take a stride parameter. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/af013bf8afc4c77ab8ff230f536e2ade973427fa TBR=bsalomon@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ea81ced1e573c98584e6830a92511f80593af0a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -167 lines) Patch
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 12 chunks +58 lines, -58 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 5 chunks +8 lines, -15 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 4 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/GrDrawState.h View 3 chunks +11 lines, -9 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrRODrawState.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrRODrawState.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
Created Revert of Make setVertexAttribs in GrDrawState take a stride parameter.
6 years, 3 months ago (2014-08-27 20:02:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/502533004/1
6 years, 3 months ago (2014-08-27 20:03:20 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 20:07:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as ea81ced1e573c98584e6830a92511f80593af0a4

Powered by Google App Engine
This is Rietveld 408576698