Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 50253002: Turn on -Werror on all non-Win platforms. (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
Reviewers:
dglazkov
CC:
blink-reviews
Visibility:
Public.

Description

Turn on -Werror on all non-Win platforms. Part of the patch by mithro@mithis.com, that part reviewed at https://codereview.chromium.org/47023014 BUG=312287 R=dglazkov@chromium.org TBR=dglazkov NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161025

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/config.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollAnimatorNone.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/platform/image-decoders/png/PNGImageDecoder.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
7 years, 1 month ago (2013-10-31 01:45:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/50253002/370001
7 years, 1 month ago (2013-10-31 01:45:51 UTC) #2
dglazkov
lgtm.
7 years, 1 month ago (2013-10-31 02:09:31 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=14852
7 years, 1 month ago (2013-10-31 03:56:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/50253002/370001
7 years, 1 month ago (2013-10-31 06:01:25 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/config.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-10-31 06:01:26 UTC) #6
Nico
7 years, 1 month ago (2013-10-31 06:08:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 manually as r161025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698