Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 47023014: Remove unused variables so -Werror can be enabled on Linux with clang. (Closed)

Created:
7 years, 1 month ago by mithro-old
Modified:
7 years, 1 month ago
Reviewers:
lgombos, Nico, dglazkov1, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@origin-master
Visibility:
Public.

Description

Remove unused variables so -Werror can be enabled on Linux with clang. (Checked that they where not referenced anywhere in the chrome repository.) R=dglazkov, lgombos BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/core/platform/ScrollAnimatorNone.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mithro-old
Please check and then I'll commit.
7 years, 1 month ago (2013-10-31 04:07:50 UTC) #1
eseidel
lgtm
7 years, 1 month ago (2013-10-31 04:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/47023014/1
7 years, 1 month ago (2013-10-31 04:11:30 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=10268
7 years, 1 month ago (2013-10-31 04:54:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/47023014/1
7 years, 1 month ago (2013-10-31 06:04:51 UTC) #5
Nico
7 years, 1 month ago (2013-10-31 06:09:03 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698