adjusting logging level for cron job

adjusting logging level for cron job

BUG=406130
Committed: https://chromium.googlesource.com/infra/infra/+/4f1879be41d224c6bc0413c3a5dd9eeece6aaea8

[friedman, 2014-08-26 19:23:25]

friedman@chromium.org changed reviewers:
+ ellyjones@chromium.org, eseidel@chromium.org, ojan@chromium.org,
stip@chromium.org

[ghost stip (do not use), 2014-08-26 19:34:44]

https://codereview.chromium.org/502483003/diff/1/infra/tools/builder_alerts/_...
File infra/tools/builder_alerts/__main__.py (right):

https://codereview.chromium.org/502483003/diff/1/infra/tools/builder_alerts/_...
infra/tools/builder_alerts/__main__.py:67:
logging.basicConfig(level=logging.CRITICAL)
why not ERROR?

[friedman, 2014-08-26 19:45:31]

On 2014/08/26 19:34:44, stip wrote:
>
https://codereview.chromium.org/502483003/diff/1/infra/tools/builder_alerts/_...
> File infra/tools/builder_alerts/__main__.py (right):
> 
>
https://codereview.chromium.org/502483003/diff/1/infra/tools/builder_alerts/_...
> infra/tools/builder_alerts/__main__.py:67:
> logging.basicConfig(level=logging.CRITICAL)
> why not ERROR?

Any HTTP error response will result in ERROR...
ERROR:root:Failed (0.2s, 500)
https://chrome-build-extract.appspot.com/p/chromium.gatekeeper/builders/Chrom...
ERROR:root:Failed (0.1s, 404)
https://chrome-build-extract.appspot.com/p/chromium.gatekeeper/builders/Chrom...

[eseidel, 2014-08-26 19:57:31]

We could also make this a command-line option.

LGTM.

[ghost stip (do not use), 2014-08-26 20:32:14]

lgtm

[friedman, 2014-08-26 21:24:35]

On 2014/08/26 20:32:14, stip wrote:
> lgtm

I can't get it to submit :(

% git cl land
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from
/usr/local/google/home/friedman/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks took 22.4s to calculate.

Presubmit checks passed.
Description:
adjusting logging level for cron job

BUG=406130
R=eseidel@chromium.org, stip@chromium.org

Review URL: https://codereview.chromium.org/502483003
 infra/tools/builder_alerts/__main__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Counting objects: 6, done.
Delta compression using up to 32 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 566 bytes | 0 bytes/s, done.
Total 6 (delta 5), reused 0 (delta 0)
remote: Resolving deltas: 100% (5/5)
remote: Processing changes: refs: 1, done
error: failed to push some refs to
'https://chromium.googlesource.com/infra/infra.git'

[ojan, 2014-08-26 22:20:46]

On 2014/08/26 at 19:57:31, eseidel wrote:
> We could also make this a command-line option.
> 
> LGTM.

Yeah, ideally if you --verbose it would DEBUG log and there would be a FIXME to
make it ERROR log instead of CRITICAL. We need to figure out how to make
requests log DEBUG in this case.

Thanks for fixing this.

[friedman, 2014-08-26 23:01:30]

On 2014/08/26 22:20:46, ojan-only-code-yellow-reviews wrote:
> On 2014/08/26 at 19:57:31, eseidel wrote:
> > We could also make this a command-line option.
> > 
> > LGTM.
> 
> Yeah, ideally if you --verbose it would DEBUG log and there would be a FIXME
to
> make it ERROR log instead of CRITICAL. We need to figure out how to make
> requests log DEBUG in this case.
> 
> Thanks for fixing this.

I give up... I cant get this thing to submit.  Can someone else make the change
and I can setup the cronjob?  I don't want to push it live and have it spam the
crap out of everyone...

[ghost stip (do not use), 2014-08-26 23:35:36]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2014-08-26 23:36:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/friedman@chromium.org/502483003/1

[commit-bot: I haz the power, 2014-08-26 23:38:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  infra_tester on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[commit-bot: I haz the power, 2014-08-26 23:40:27]

Committed patchset #1 (1) as 4f1879be41d224c6bc0413c3a5dd9eeece6aaea8