Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: media/cast/sender/frame_sender.h

Issue 502333002: [Cast] In Audio/VideoSender, drop frames when too-long a duration is in-flight. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/frame_sender.h
diff --git a/media/cast/sender/frame_sender.h b/media/cast/sender/frame_sender.h
index 5da3927961f7262aca2774ffd60254610c4b17b6..b6580bd180be86c374092ece4e60c253de5eef10 100644
--- a/media/cast/sender/frame_sender.h
+++ b/media/cast/sender/frame_sender.h
@@ -94,6 +94,11 @@ class FrameSender {
// new frames shall halt.
int max_unacked_frames_;
+ // Maximum difference between a new frame's RTP timestamp and the oldest
+ // unacked frame's RTP timestamp, before encoding and sending of new frames
+ // shall halt.
+ int64 max_unacked_rtp_delta_;
hubbe 2014/08/26 17:49:56 Why not TimeDelta?
miu 2014/08/26 19:57:19 It more convenient to have in the time calculation
hubbe 2014/08/26 20:54:21 This is an odd situation. Usually you're the one w
miu 2014/08/26 23:27:16 Done. I rewrote it the other way. The ShouldDrop
+
private:
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<FrameSender> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698