Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: media/cast/sender/rtp_timestamp_helper.h

Issue 502333002: [Cast] In Audio/VideoSender, drop frames when too-long a duration is in-flight. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/rtp_timestamp_helper.h
diff --git a/media/cast/sender/rtp_timestamp_helper.h b/media/cast/sender/rtp_timestamp_helper.h
index 8f56681dac3651579884f8ce619a61718677c21a..2146e22d5412200c72352ff97950e13fbc4748e9 100644
--- a/media/cast/sender/rtp_timestamp_helper.h
+++ b/media/cast/sender/rtp_timestamp_helper.h
@@ -17,11 +17,13 @@ class RtpTimestampHelper {
explicit RtpTimestampHelper(int frequency);
~RtpTimestampHelper();
- // Compute a RTP timestamp using current time, last encoded time and
- // last encoded RTP timestamp.
- // Return true if |rtp_timestamp| is computed.
- bool GetCurrentTimeAsRtpTimestamp(const base::TimeTicks& now,
- uint32* rtp_timestamp) const;
+ int frequency() const { return frequency_; }
+
+ // Compute a RTP timestamp for |t|, based on the last stored capture time and
+ // its corresponding RTP timestamp. Return true if |rtp_timestamp| is
+ // computed.
+ bool EstimateRtpTimestamp(const base::TimeTicks& t,
hubbe 2014/08/26 17:49:56 Why is it an estimate? Does it return "approximate
miu 2014/08/26 19:57:19 Yes. It's an estimate because, ultimately, it's t
hubbe 2014/08/26 20:54:21 If we do this with timeticks/deltas instead, do we
miu 2014/08/26 23:27:16 Done. This method is also used when generating SR
+ uint32* rtp_timestamp) const;
// Store the capture time and the corresponding RTP timestamp for the
// last encoded frame.

Powered by Google App Engine
This is Rietveld 408576698