Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 502293002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
yurys
CC:
aandrey+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/f4b5657639f866762e4226e46008a16661187139 Cr-Commit-Position: refs/heads/master@{#292113}

Patch Set 1 #

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + yurys@chromium.org
6 years, 4 months ago (2014-08-26 00:35:47 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-26 00:49:39 UTC) #2
yurys
lgtm
6 years, 3 months ago (2014-08-27 06:03:22 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 06:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/502293002/1
6 years, 3 months ago (2014-08-27 06:06:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 7d5bc579cf6dc154a83c22ea786aaefc356ab993
6 years, 3 months ago (2014-08-27 06:59:58 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4b5657639f866762e4226e46008a16661187139
Cr-Commit-Position: refs/heads/master@{#292113}

Powered by Google App Engine
This is Rietveld 408576698