Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5196)

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 502293002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/device/adb/mock_adb_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
index 61d6955d3bfbda51dad1611b253e12988f9e128b..b6e2ec09901de0838200a1144c521d2ac706b0ef 100644
--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
@@ -71,23 +71,23 @@ class AdbClientSocketTest : public InProcessBrowserTest,
scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> chrome =
FindBrowserByDisplayName(browsers, "Chrome");
- ASSERT_TRUE(chrome);
+ ASSERT_TRUE(chrome.get());
scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> chrome_beta =
FindBrowserByDisplayName(browsers, "Chrome Beta");
- ASSERT_TRUE(chrome_beta);
+ ASSERT_TRUE(chrome_beta.get());
scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> chromium =
FindBrowserByDisplayName(browsers, "Chromium");
- ASSERT_FALSE(chromium);
+ ASSERT_FALSE(chromium.get());
scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> webview =
FindBrowserByDisplayName(browsers, "WebView in com.sample.feed");
- ASSERT_TRUE(webview);
+ ASSERT_TRUE(webview.get());
scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> noprocess =
FindBrowserByDisplayName(browsers, "Noprocess");
- ASSERT_TRUE(noprocess);
+ ASSERT_TRUE(noprocess.get());
ASSERT_EQ("32.0.1679.0", chrome->version());
ASSERT_EQ("31.0.1599.0", chrome_beta->version());
« no previous file with comments | « no previous file | chrome/browser/devtools/device/adb/mock_adb_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698