Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.cc

Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_view_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_view_devtools_agent_host.cc b/content/browser/devtools/render_view_devtools_agent_host.cc
index 301b60d3422622811f2233dd5a90e6f55818bc65..12a05d55b746b29c5a929e1c78d99b299d944bfb 100644
--- a/content/browser/devtools/render_view_devtools_agent_host.cc
+++ b/content/browser/devtools/render_view_devtools_agent_host.cc
@@ -138,7 +138,7 @@ void RenderViewDevToolsAgentHost::DispatchProtocolMessage(
scoped_refptr<DevToolsProtocol::Command> command =
DevToolsProtocol::ParseCommand(message_dict.get(), &error_message);
- if (command) {
+ if (command.get()) {
scoped_refptr<DevToolsProtocol::Response> overridden_response;
DevToolsManagerDelegate* delegate =
@@ -150,13 +150,13 @@ void RenderViewDevToolsAgentHost::DispatchProtocolMessage(
overridden_response = DevToolsProtocol::ParseResponse(
overridden_response_value.get());
}
- if (!overridden_response)
+ if (!overridden_response.get())
overridden_response = overrides_handler_->HandleCommand(command);
- if (!overridden_response)
+ if (!overridden_response.get())
overridden_response = tracing_handler_->HandleCommand(command);
- if (!overridden_response)
+ if (!overridden_response.get())
overridden_response = power_handler_->HandleCommand(command);
- if (overridden_response) {
+ if (overridden_response.get()) {
if (!overridden_response->is_async_promise())
OnDispatchOnInspectorFrontend(overridden_response->Serialize());
return;
@@ -478,7 +478,7 @@ void RenderViewDevToolsAgentHost::OnDispatchOnInspectorFrontend(
scoped_refptr<DevToolsProtocol::Notification> notification =
DevToolsProtocol::ParseNotification(message);
- if (notification) {
+ if (notification.get()) {
tracing_handler_->HandleNotification(notification);
}
SendMessageToClient(message);

Powered by Google App Engine
This is Rietveld 408576698