Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: content/browser/devtools/devtools_browser_target.cc

Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_browser_target.cc
diff --git a/content/browser/devtools/devtools_browser_target.cc b/content/browser/devtools/devtools_browser_target.cc
index b050152d2e405d80b063e5b6863831fb6a7d3480..ac78f1d40a598d26ede38f3c288be3f0dbb3fff9 100644
--- a/content/browser/devtools/devtools_browser_target.cc
+++ b/content/browser/devtools/devtools_browser_target.cc
@@ -52,7 +52,7 @@ void DevToolsBrowserTarget::HandleMessage(const std::string& data) {
std::string error_response;
scoped_refptr<DevToolsProtocol::Command> command =
DevToolsProtocol::ParseCommand(data, &error_response);
- if (!command) {
+ if (!command.get()) {
Respond(error_response);
return;
}
@@ -81,9 +81,9 @@ void DevToolsBrowserTarget::HandleMessage(const std::string& data) {
if (handle_directly) {
scoped_refptr<DevToolsProtocol::Response> response =
handler->HandleCommand(command);
- if (response && response->is_async_promise())
+ if (response.get() && response->is_async_promise())
return;
- if (response)
+ if (response.get())
Respond(response->Serialize());
else
Respond(command->NoSuchMethodErrorResponse()->Serialize());
@@ -148,10 +148,10 @@ void DevToolsBrowserTarget::HandleCommandOnUIThread(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
scoped_refptr<DevToolsProtocol::Response> response =
handler->HandleCommand(command);
- if (response && response->is_async_promise())
+ if (response.get() && response->is_async_promise())
return;
- if (response)
+ if (response.get())
RespondFromUIThread(response->Serialize());
else
RespondFromUIThread(command->NoSuchMethodErrorResponse()->Serialize());
« no previous file with comments | « no previous file | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698