Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 502183002: Don't use msmpeg2vdec.dll version 6.1.7140 (Closed)

Created:
6 years, 4 months ago by luken
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't use msmpeg2vdec.dll version 6.1.7140 This version of the dll seems to be causing a disproportionate number of crashes, so we fall back to software decoding if that is the version of the DLL on the user's machine. BUG=403440 Committed: https://crrev.com/61b78e43a64f95913e16f13a9a171881902d30d3 Cr-Commit-Position: refs/heads/master@{#292040}

Patch Set 1 #

Patch Set 2 : use FileVersionInfo to get version #

Total comments: 2

Patch Set 3 : adding crbug link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
luken
luken@chromium.org changed reviewers: + scherkus@chromium.org
6 years, 3 months ago (2014-08-26 20:11:22 UTC) #1
luken
6 years, 3 months ago (2014-08-26 20:11:22 UTC) #2
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/502183002/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/502183002/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode644 content/common/gpu/media/dxva_video_decode_accelerator.cc:644: // fall back to software decoding. ...
6 years, 3 months ago (2014-08-26 20:31:44 UTC) #3
luken
https://codereview.chromium.org/502183002/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/502183002/diff/20001/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode644 content/common/gpu/media/dxva_video_decode_accelerator.cc:644: // fall back to software decoding. On 2014/08/26 20:31:44, ...
6 years, 3 months ago (2014-08-26 22:59:25 UTC) #4
luken
The CQ bit was checked by luken@chromium.org
6 years, 3 months ago (2014-08-26 22:59:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luken@chromium.org/502183002/40001
6 years, 3 months ago (2014-08-26 23:02:17 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (40001) as c56e44b0724f03bad2d4c3069a177abf9c94edd4
6 years, 3 months ago (2014-08-27 00:00:20 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:47:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61b78e43a64f95913e16f13a9a171881902d30d3
Cr-Commit-Position: refs/heads/master@{#292040}

Powered by Google App Engine
This is Rietveld 408576698