Don't use msmpeg2vdec.dll version 6.1.7140

content/common/gpu/media/dxva_video_decode_accelerator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/dxva_video_decode_accelerator.h"
 
 #if !defined(OS_WIN)
 #error This file should only be built on Windows.
 #endif   // !defined(OS_WIN)
 
 #include <ks.h>
 #include <codecapi.h>
 #include <mfapi.h>
 #include <mferror.h>
 #include <wmcodecdsp.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
+#include "base/file_version_info.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/shared_memory.h"
 #include "base/message_loop/message_loop.h"
 #include "base/win/windows_version.h"
 #include "media/video/video_decode_accelerator.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_surface_egl.h"
 #include "ui/gl/gl_switches.h"
 
@@ skipping 600 matching lines @@
 
   // We mimic the steps CoCreateInstance uses to instantiate the object. This
   // was previously done because it failed inside the sandbox, and now is done
   // as a more minimal approach to avoid other side-effects CCI might have (as
   // we are still in a reduced sandbox).
   HMODULE decoder_dll = ::LoadLibrary(L"msmpeg2vdec.dll");
   RETURN_ON_FAILURE(decoder_dll,
                     "msmpeg2vdec.dll required for decoding is not loaded",
                     false);
 
+  // Check version of DLL, version 6.7.7140 is blacklisted due to high crash
+  // rates in browsers loading that DLL. If that is the version installed we
+  // fall back to software decoding.

[scherkus (not reviewing), 2014/08/26 20:31:44]

nit: link to crbug

[luken, 2014/08/26 22:59:25]

Done.

+  FileVersionInfo* version_info =
+      FileVersionInfo::CreateFileVersionInfoForModule(decoder_dll);
+  RETURN_ON_FAILURE(version_info,
+                    "unable to get version of msmpeg2vdec.dll",
+                    false);
+  base::string16 file_version = version_info->file_version();
+  RETURN_ON_FAILURE(file_version.find(L"6.1.7140") == base::string16::npos,
+                    "blacklisted version of msmpeg2vdec.dll 6.7.7140",
+                    false);
+
   typedef HRESULT(WINAPI * GetClassObject)(
       const CLSID & clsid, const IID & iid, void * *object);
 
   GetClassObject get_class_object = reinterpret_cast<GetClassObject>(
       GetProcAddress(decoder_dll, "DllGetClassObject"));
   RETURN_ON_FAILURE(
       get_class_object, "Failed to get DllGetClassObject pointer", false);
 
   base::win::ScopedComPtr<IClassFactory> factory;
   HRESULT hr = get_class_object(__uuidof(CMSH264DecoderMFT),
@@ skipping 526 matching lines @@
 
   for (index = picture_buffers.begin();
        index != picture_buffers.end();
        ++index) {
     DVLOG(1) << "Dismissing picture id: " << index->second->id();
     client_->DismissPictureBuffer(index->second->id());
   }
 }
 
 }  // namespace content