Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 502173002: Move more metrics classes to metrics namespace. (Closed)

Created:
6 years, 4 months ago by Alexei Svitkine (slow)
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman, jam, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move more metrics classes to metrics namespace. BUG=374763 TBR=jam@chromium.org Committed: https://crrev.com/cbd420738577e75f86d88d81da65661b588aa950 Cr-Commit-Position: refs/heads/master@{#291994}

Patch Set 1 #

Patch Set 2 : Fix unit test compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -110 lines) Patch
M base/threading/thread_restrictions.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/browser_process.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 9 chunks +20 lines, -14 lines 0 comments Download
M chrome/browser/chrome_browser_metrics_service_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/extensions_metrics_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/metrics/extensions_metrics_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_reporting_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service_accessor.h View 1 chunk +11 lines, -6 lines 0 comments Download
M chrome/browser/metrics/metrics_service_accessor.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_services_manager.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_services_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/omnibox_metrics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/profiler_metrics_provider.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_log.h View 8 chunks +15 lines, -13 lines 0 comments Download
M components/metrics/metrics_log.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/metrics/metrics_reporting_scheduler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_reporting_scheduler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_reporting_scheduler_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_service.h View 10 chunks +20 lines, -17 lines 0 comments Download
M components/metrics/metrics_service.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/metrics/metrics_service_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_service_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_service_unittest.cc View 9 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexei Svitkine (slow)
6 years, 4 months ago (2014-08-25 20:46:43 UTC) #1
Ilya Sherman
LGTM. Thanks :)
6 years, 4 months ago (2014-08-26 00:36:59 UTC) #2
Alexei Svitkine (slow)
asvitkine@chromium.org changed reviewers: + jam@chromium.org, sky@chromium.org
6 years, 3 months ago (2014-08-26 02:51:04 UTC) #3
Alexei Svitkine (slow)
+jam, +sky for owners sky: chrome/ jam: base/threading
6 years, 3 months ago (2014-08-26 02:51:04 UTC) #4
sky
LGTM
6 years, 3 months ago (2014-08-26 16:47:31 UTC) #5
Alexei Svitkine (slow)
TBR=jam@chromium.org for trivial namespace change to thread restrictions friend list
6 years, 3 months ago (2014-08-26 20:16:14 UTC) #6
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 3 months ago (2014-08-26 20:16:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/502173002/20001
6 years, 3 months ago (2014-08-26 20:18:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (20001) as 12e677f70386b4ce7efa4f774d14f7bbd0956b10
6 years, 3 months ago (2014-08-26 22:16:04 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:46:03 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cbd420738577e75f86d88d81da65661b588aa950
Cr-Commit-Position: refs/heads/master@{#291994}

Powered by Google App Engine
This is Rietveld 408576698