Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3530)

Unified Diff: chrome/browser/metrics/metrics_service_accessor.h

Issue 502173002: Move more metrics classes to metrics namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test compile. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service_accessor.h
diff --git a/chrome/browser/metrics/metrics_service_accessor.h b/chrome/browser/metrics/metrics_service_accessor.h
index 7883f7310f0cfa68100865cbc1957c6f66c40942..df2f3e0f49ddd9cd053aa4d00c4c03fe7efffe19 100644
--- a/chrome/browser/metrics/metrics_service_accessor.h
+++ b/chrome/browser/metrics/metrics_service_accessor.h
@@ -10,30 +10,35 @@
#include "base/macros.h"
+namespace metrics {
class MetricsService;
class MetricsServiceObserver;
+}
// This class limits and documents access to metrics service helper methods.
// These methods are protected so each user has to inherit own program-specific
// specialization and enable access there by declaring friends.
class MetricsServiceAccessor {
protected:
- // Constructor declared as protected to enable inheritance. Decendants should
+ // Constructor declared as protected to enable inheritance. Descendants should
// disallow instantiation.
MetricsServiceAccessor() {}
// Registers/unregisters |observer| to receive MetricsLog notifications
// from metrics service.
- static void AddMetricsServiceObserver(MetricsServiceObserver* observer);
- static void RemoveMetricsServiceObserver(MetricsServiceObserver* observer);
+ static void AddMetricsServiceObserver(
+ metrics::MetricsServiceObserver* observer);
+ static void RemoveMetricsServiceObserver(
+ metrics::MetricsServiceObserver* observer);
// Registers the specified synthetic field trial (identified by a hash of the
// trial name and group name) with |metrics_service|, if the service is not
// NULL, returning true on success.
// See the comment on MetricsService::RegisterSyntheticFieldTrial for details.
- static bool RegisterSyntheticFieldTrial(MetricsService* metrics_service,
- uint32_t trial_name_hash,
- uint32_t group_name_hash);
+ static bool RegisterSyntheticFieldTrial(
+ metrics::MetricsService* metrics_service,
+ uint32_t trial_name_hash,
+ uint32_t group_name_hash);
private:
DISALLOW_COPY_AND_ASSIGN(MetricsServiceAccessor);
« no previous file with comments | « chrome/browser/metrics/metrics_reporting_state.cc ('k') | chrome/browser/metrics/metrics_service_accessor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698