Issue 502163002: Fix GN toolchains to use proper out dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502163002: Fix GN toolchains to use proper out dir. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/d40ebfebd18d8fc41a0f5af61d28b6c252b66bea Cr-Commit-Position: refs/heads/master@{#291927}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -32 lines)			Patch
M	BUILD.gn	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	build/toolchain/gcc_toolchain.gni	View		3 chunks	+15 lines, -14 lines	0 comments	Download
M	build/toolchain/mac/BUILD.gn	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/toolchain/win/BUILD.gn	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	components/variations.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/variations/BUILD.gn	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	mojo/services/surfaces/BUILD.gn	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

brettw

Committed patchset #3 to pending queue manually as 8ffd088.

6 years, 3 months ago (2014-08-26 17:40:21 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:43:36 UTC) #4

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/d40ebfebd18d8fc41a0f5af61d28b6c252b66bea
Cr-Commit-Position: refs/heads/master@{#291927}