Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: BUILD.gn

Issue 502163002: Fix GN toolchains to use proper out dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1b81c35c878567bd5d3bf55651ea1782022caf5f..6ed045c2ec436be10205fa5d9f436d4d5c71f641 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -10,17 +10,6 @@
import("//build/config/ui.gni")
-# Android GN build has some bugs: http://crbug.com/405686
-if (is_android) {
-
-group("root") {
- deps = [
- "//base",
- ]
-}
-
-} else {
-
# In GN, a "group" is a dummy target that just lists other targets.
group("root") {
# Note that some dependencies are commented out. These are things that are
@@ -248,5 +237,3 @@ group("root") {
]
}
}
-
-}
« no previous file with comments | « no previous file | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698