Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 502088: Remove Sazanami Gothic from IDS_FIXED_FONT_FAMILY and IDS_SANS_SERIF_FONT_FAMILY. (Closed)

Created:
11 years ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, ben+cc_chromium.org, John Grabowski, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), jungshik at Google
Visibility:
Public.

Description

Remove Sazanami Gothic from IDS_FIXED_FONT_FAMILY and IDS_SANS_SERIF_FONT_FAMILY. It turned out the values of these fields are used for the "Fonts and Languages" dialog, so use of commas is not allowed. On the other hand, IDS_WEB_FONT_FAMILY seems to be used for generating HTML so use of commas is fine. For instance: chrome/browser/dom_ui/chrome_url_data_manager.cc: void ChromeURLDataManager::DataSource::SetFontAndTextDirection( DictionaryValue* localized_strings) { localized_strings->SetString(L"fontfamily", l10n_util::GetString(IDS_WEB_FONT_FAMILY)); chrome/browser/dom_ui/history_ui.cc: SetFontAndTextDirection(&localized_strings); static const base::StringPiece history_html( ResourceBundle::GetSharedInstance().GetRawDataResource( IDR_HISTORY_HTML)); const std::string full_html = jstemplate_builder::GetI18nTemplateHtml( history_html, &localized_strings); BUG=30758 TEST=locally ran "LANGUAGE=ja chrome" and confirmed that specified fonts are shown in the "Fonts and Languages" dialog, and Japanese pages are rendered with VL Gothic/PGothic. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35081

Patch Set 1 #

Patch Set 2 : git pull in trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/resources/locale_settings_ja.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
11 years ago (2009-12-21 01:50:35 UTC) #1
Yusuke Sato
11 years ago (2009-12-21 01:54:01 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698