Chromium Code Reviews
DescriptionRemove Sazanami Gothic from IDS_FIXED_FONT_FAMILY and IDS_SANS_SERIF_FONT_FAMILY.
It turned out the values of these fields are used for the "Fonts and
Languages" dialog, so use of commas is not allowed.
On the other hand, IDS_WEB_FONT_FAMILY seems to be used for generating
HTML so use of commas is fine. For instance:
chrome/browser/dom_ui/chrome_url_data_manager.cc:
void ChromeURLDataManager::DataSource::SetFontAndTextDirection(
DictionaryValue* localized_strings) {
localized_strings->SetString(L"fontfamily",
l10n_util::GetString(IDS_WEB_FONT_FAMILY));
chrome/browser/dom_ui/history_ui.cc:
SetFontAndTextDirection(&localized_strings);
static const base::StringPiece history_html(
ResourceBundle::GetSharedInstance().GetRawDataResource(
IDR_HISTORY_HTML));
const std::string full_html = jstemplate_builder::GetI18nTemplateHtml(
history_html, &localized_strings);
BUG=30758
TEST=locally ran "LANGUAGE=ja chrome" and confirmed that specified fonts are shown in
the "Fonts and Languages" dialog, and Japanese pages are rendered with VL Gothic/PGothic.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35081
Patch Set 1 #Patch Set 2 : git pull in trunk #Messages
Total messages: 2 (0 generated)
|