Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 501993003: Remove implicit conversions from scoped_refptr to T* in components/nacl/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/nacl/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/a5c8bbd3f4861a20fc515c8ce4709f2d27323f89 Cr-Commit-Position: refs/heads/master@{#291959}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/nacl/browser/nacl_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/browser/pnacl_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/pnacl_translation_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + mseaborn@chromium.org
6 years, 3 months ago (2014-08-26 16:25:18 UTC) #1
dcheng
6 years, 3 months ago (2014-08-26 16:25:18 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/501993003/diff/1/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/501993003/diff/1/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode75 components/nacl/renderer/ppb_nacl_private_impl.cc:75: base::LazyInstance<scoped_refptr<PnaclTranslationResourceHost> > As an aside, this use of ...
6 years, 3 months ago (2014-08-26 18:31:53 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 18:32:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/501993003/1
6 years, 3 months ago (2014-08-26 18:33:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 4facb84d13d26dfbc74dd913259785cf2376d7ff
6 years, 3 months ago (2014-08-26 19:20:20 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5c8bbd3f4861a20fc515c8ce4709f2d27323f89
Cr-Commit-Position: refs/heads/master@{#291959}

Powered by Google App Engine
This is Rietveld 408576698