Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: components/nacl/browser/pnacl_translation_cache_unittest.cc

Issue 501993003: Remove implicit conversions from scoped_refptr to T* in components/nacl/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/pnacl_translation_cache_unittest.cc
diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc
index 1cc903b7c95277f0a5b743c796a00819cc327d15..98cfbe7f366c6df06aea6b1fdd9eb0e0eea2b526 100644
--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc
+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc
@@ -68,7 +68,7 @@ void PnaclTranslationCacheTest::StoreNexe(const std::string& key,
net::TestCompletionCallback store_cb;
scoped_refptr<net::DrainableIOBuffer> nexe_buf(
new net::DrainableIOBuffer(new net::StringIOBuffer(nexe), nexe.size()));
- cache_->StoreNexe(key, nexe_buf, store_cb.callback());
+ cache_->StoreNexe(key, nexe_buf.get(), store_cb.callback());
// Using ERR_IO_PENDING here causes the callback to wait for the result
// which should be harmless even if it returns OK immediately. This is because
// we don't plumb the intermediate writing stages all the way out.
@@ -226,7 +226,7 @@ TEST_F(PnaclTranslationCacheTest, InMemSizeLimit) {
new net::StringIOBuffer(std::string(kMaxMemCacheSize + 1, 'a')),
kMaxMemCacheSize + 1));
net::TestCompletionCallback store_cb;
- cache_->StoreNexe(test_key, large_buffer, store_cb.callback());
+ cache_->StoreNexe(test_key, large_buffer.get(), store_cb.callback());
EXPECT_EQ(net::ERR_FAILED, store_cb.GetResult(net::ERR_IO_PENDING));
base::RunLoop().RunUntilIdle(); // Ensure the entry is closed.
EXPECT_EQ(0, cache_->Size());

Powered by Google App Engine
This is Rietveld 408576698