Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index ffa47047b947abf39d9cfafae716e55553a2d320..133d3309c8edb1273ff8d03657112a987667ff53 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -29,10 +29,9 @@
class SkBitmap;
class FrameMsg_Navigate;
+struct FrameMsg_Navigate_Params;
struct MediaPlayerAction;
struct ViewHostMsg_CreateWindow_Params;
-struct ViewHostMsg_ShowPopup_Params;
-struct FrameMsg_Navigate_Params;
struct ViewMsg_PostMessage_Params;
namespace base {
@@ -336,23 +335,12 @@ class CONTENT_EXPORT RenderViewHostImpl
// Creates a full screen RenderWidget.
void CreateNewFullscreenWidget(int route_id);
-#if defined(OS_MACOSX)
- // Select popup menu related methods (for external popup menus).
- void DidSelectPopupMenuItem(int selected_index);
- void DidCancelPopupMenu();
-#endif
-
#if defined(ENABLE_BROWSER_CDMS)
MediaWebContentsObserver* media_web_contents_observer() {
return media_web_contents_observer_.get();
}
#endif
-#if defined(OS_ANDROID)
- void DidSelectPopupMenuItems(const std::vector<int>& selected_indices);
- void DidCancelPopupMenu();
-#endif
-
int main_frame_routing_id() const {
return main_frame_routing_id_;
}
@@ -438,11 +426,6 @@ class CONTENT_EXPORT RenderViewHostImpl
void OnRunFileChooser(const FileChooserParams& params);
void OnFocusedNodeTouched(bool editable);
-#if defined(OS_MACOSX) || defined(OS_ANDROID)
- void OnShowPopup(const ViewHostMsg_ShowPopup_Params& params);
- void OnHidePopup();
-#endif
-
private:
// TODO(nasko): Temporarily friend RenderFrameHostImpl, so we don't duplicate
// utility functions and state needed in both classes, while we move frame
« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate_view.h ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698