Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: content/browser/renderer_host/render_view_host_delegate_view.h

Issue 501583003: Move external popup menus from WebViewClient to WebFrameClient, part 3/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_delegate_view.h
diff --git a/content/browser/renderer_host/render_view_host_delegate_view.h b/content/browser/renderer_host/render_view_host_delegate_view.h
index fb2babdc87f5e54cf186b5b3f330f4570ac93355..0ff4a000c6e71c3dba73e780db785e372a3533de 100644
--- a/content/browser/renderer_host/render_view_host_delegate_view.h
+++ b/content/browser/renderer_host/render_view_host_delegate_view.h
@@ -36,20 +36,6 @@ class CONTENT_EXPORT RenderViewHostDelegateView {
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) {}
- // Shows a popup menu with the specified items.
- // This method should call RenderViewHost::DidSelectPopupMenuItem[s]() or
- // RenderViewHost::DidCancelPopupMenu() based on the user action.
- virtual void ShowPopupMenu(const gfx::Rect& bounds,
- int item_height,
- double item_font_size,
- int selected_item,
- const std::vector<MenuItem>& items,
- bool right_aligned,
- bool allow_multiple_selection) {};
-
- // Hides a popup menu opened by ShowPopupMenu().
- virtual void HidePopupMenu() {};
-
// The user started dragging content of the specified type within the
// RenderView. Contextual information about the dragged content is supplied
// by DropData. If the delegate's view cannot start the drag for /any/
@@ -73,6 +59,23 @@ class CONTENT_EXPORT RenderViewHostDelegateView {
// retrieved by doing a Shift-Tab.
virtual void TakeFocus(bool reverse) {}
+#if defined(OS_MACOSX) || defined(OS_ANDROID)
+ // Shows a popup menu with the specified items.
+ // This method should call RenderFrameHost::DidSelectPopupMenuItem[s]() or
+ // RenderFrameHost::DidCancelPopupMenu() based on the user action.
+ virtual void ShowPopupMenu(RenderFrameHost* render_frame_host,
+ const gfx::Rect& bounds,
+ int item_height,
+ double item_font_size,
+ int selected_item,
+ const std::vector<MenuItem>& items,
+ bool right_aligned,
+ bool allow_multiple_selection) {};
+
+ // Hides a popup menu opened by ShowPopupMenu().
+ virtual void HidePopupMenu() {};
+#endif
+
protected:
virtual ~RenderViewHostDelegateView() {}
};
« no previous file with comments | « content/browser/renderer_host/popup_menu_helper_mac.mm ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698