Replace our homegrown ARRAY_SIZE() with Chrome's arraysize().

Replace our homegrown ARRAY_SIZE() with Chrome's arraysize().

Our own ARRAY_SIZE() was pretty bad at error checking. If you use
arrasize() in a wrong way, the compiler will issue an error instead of
silently doing the wrong thing. The previous ARRAY_SIZE() macro is still
available as ARRAYSIZE_UNSAFE() similar to Chrome.

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23389

[Benedikt Meurer, 2014-08-26 09:09:02]

bmeurer@chromium.org changed reviewers:
+ yangguo@chromium.org

[Benedikt Meurer, 2014-08-26 09:09:02]

PTAL

[Yang, 2014-08-26 09:17:22]

LGTM. Rubberstamped most.

https://codereview.chromium.org/501323002/diff/1/src/base/macros.h
File src/base/macros.h (right):

https://codereview.chromium.org/501323002/diff/1/src/base/macros.h#newcode88
src/base/macros.h:88: #define ARRAYSIZE_UNSAFE(a)     \
Do we actually need this?

[Benedikt Meurer, 2014-08-26 09:20:07]

Committed patchset #1 manually as 23389 (presubmit successful).

[refack, 2014-09-10 09:44:58]

On 2014/08/26 09:20:07, Benedikt Meurer wrote:
> Committed patchset #1 manually as 23389 (presubmit successful).

Any Idea why I still can't build this on Ubuntu 14 x64 (GCC 4.8.8 / GCC 4.9.1 /
Clang 3.5.1)?
something failing about instantiating the template

[Benedikt Meurer, 2014-09-11 04:43:21]

On 2014/09/10 at 09:44:58, refack wrote:
> On 2014/08/26 09:20:07, Benedikt Meurer wrote:
> > Committed patchset #1 manually as 23389 (presubmit successful).
> 
> Any Idea why I still can't build this on Ubuntu 14 x64 (GCC 4.8.8 / GCC 4.9.1
/ Clang 3.5.1)?
> something failing about instantiating the template

What is this "something" that is failing? Maybe you can file a bug report with
detailed error messages.